Skip to content

Hide link when model file does not exist#2348

Merged
koesie10 merged 1 commit intomainfrom
koesie10/non-existing-model-file
Apr 19, 2023
Merged

Hide link when model file does not exist#2348
koesie10 merged 1 commit intomainfrom
koesie10/non-existing-model-file

Conversation

@koesie10
Copy link
Copy Markdown
Member

This removes the link to the model file when it does not exist. It will still show the filename of the model file. When clicking on "Apply", it will refresh whether the model file exists after writing the file.

Screenshot 2023-04-18 at 15 48 31

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This removes the link to the model file when it does not exist. It will
still show the filename of the model file. When clicking on "Apply", it
will refresh whether the model file exists after writing the file.
@koesie10 koesie10 requested a review from starcke April 18, 2023 13:48
@koesie10 koesie10 requested review from a team as code owners April 18, 2023 13:48
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koesie10 koesie10 merged commit 3f7b8a6 into main Apr 19, 2023
@koesie10 koesie10 deleted the koesie10/non-existing-model-file branch April 19, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants